-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if a virtual file change but nothing changed: set it as in sync #6621
Conversation
d023c0b
to
2bae949
Compare
617e1ac
to
d89dab5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
d89dab5
to
ee0c339
Compare
@mgallien maybe you could add to the commit message why the virtual file would change, like in this case Outlook was changing the file. |
ee0c339
to
7341b7a
Compare
done |
some software (at least outlook native software) may fiddle with CfApi placeholder metadta and set a .msg file to be out of sync state when opening it in that case, we will let the sync engine go over it and decide what to do it is then possible in that case that we would just put it back in "in sync" state Signed-off-by: Matthieu Gallien <[email protected]>
7341b7a
to
1522d01
Compare
/backport to stable-3.12 |
/backport to stable-3.13 |
The backport to # Switch to the target branch and update it
git checkout stable-3.12
git pull origin stable-3.12
# Create the new backport branch
git checkout -b backport/6621/stable-3.12
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1522d01d
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6621/stable-3.12 Error: Failed to clone repository: Failed to checkout branches: error: Your local changes to the following files would be overwritten by checkout: Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
AppImage file: nextcloud-PR-6621-1522d01d5b21a808e190c0b6d8c895b1a075ca3a-x86_64.AppImage |
Quality Gate passedIssues Measures |
some software (at least outlook native software) may fiddle with CfApi placeholder metadata and set a .msg file to be out of sync state when opening it
in that case, we will let the sync engine go over it and decide what to do
it is then possible in that case that we would just put it back in "in sync" state